Skip to content

fix: process validation report fails when service date fields are empty#978

Merged
davidgamez merged 3 commits intomainfrom
fix/update_validation_report_service_date
Mar 11, 2025
Merged

fix: process validation report fails when service date fields are empty#978
davidgamez merged 3 commits intomainfrom
fix/update_validation_report_service_date

Conversation

@davidgamez
Copy link
Copy Markdown
Member

@davidgamez davidgamez commented Mar 11, 2025

Summary:

The process validation report fails when an empty string("") is found on the JSON value. This PR ignores the empty string values from the fields; it also adds a helper method to be used in similar situations.

Expected behavior:

The process validation report function should account for missing or empty service date fields

From our AI friend

This pull request includes several changes to add new functionality and improve the codebase for the functions-python project. The most important changes include adding a new helper function get_nested_value, updating the README.md file with instructions for generating HTML coverage reports, and refactoring the generate_report_entities function to use the new helper function.

New functionality:

Documentation updates:

  • functions-python/README.md: Updated the README file to include instructions for running tests and generating HTML coverage reports.

Code refactoring:

Testing tips:

Teste in DEV, link

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez marked this pull request as ready for review March 11, 2025 18:36
@davidgamez davidgamez linked an issue Mar 11, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez davidgamez merged commit 465bc5d into main Mar 11, 2025
9 checks passed
@davidgamez davidgamez deleted the fix/update_validation_report_service_date branch March 11, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Process validation report fails when service date fields are empty

2 participants